Re: Bug report: Set exec->backward_compatibility flag before TT CV program re-execution
Alexei Podtelezhnikov <[email protected]> Wed, 15 Oct 2025 22:32:59 -0400
| Newsgroups | gmane.comp.fonts.freetype.devel |
|---|---|
| Message-ID | <[email protected]> |
--Apple-Mail-CFCACC8F-D8AC-4538-8F29-8B9DDF75C9EF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Werner, Besides the change below or something similar. How should we handle the flag= *during* the CV execution? Right now the CV program does not change it unti= l it is complete. In other wards, should we care about it while moving twili= ght points in the CV program? Right now we ignore the flag presumably. Alexei > On Oct 15, 2025, at 21:32, Honnesh Ramachandra <[email protected]> wr= ote: >=20 > =EF=BB=BF > Great. Here is a diff of the proposed changes in that case in ttgload.c >=20 > @@ -2201,7 +2201,6 @@ > TT_Driver driver =3D (TT_Driver)FT_FACE_DRIVER( glyph->fac= e ); > #endif > =20 > - > if ( size->bytecode_ready > 0 ) > return size->bytecode_ready; > if ( size->bytecode_ready < 0 ) > @@ -2215,6 +2214,7 @@ > } > =20 > exec =3D size->context; > + exec->backward_compatibility =3D 0; > =20 > #ifdef TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL > if ( driver->interpreter_version =3D=3D TT_INTERPRETER_VERSION_40 )= > =20 >=20 --Apple-Mail-CFCACC8F-D8AC-4538-8F29-8B9DDF75C9EF Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><head><meta http-equiv=3D"content-type" content=3D"text/html; charset=3D= utf-8"></head><body dir=3D"auto"><div dir=3D"ltr">Werner,</div><div dir=3D"l= tr"><br></div><div dir=3D"ltr">Besides the change below or something similar= . How should we handle the flag *during* the CV execution? Right now the CV p= rogram does not change it until it is complete. In other wards, should we ca= re about it while moving twilight points in the CV program? Right now w= e ignore the flag presumably.</div><div dir=3D"ltr"><br></div><div dir=3D"lt= r">Alexei</div><div dir=3D"ltr"><br><blockquote type=3D"cite">On Oct 15, 202= 5, at 21:32, Honnesh Ramachandra <[email protected]> wrote:<br><b= r></blockquote></div><blockquote type=3D"cite"><div dir=3D"ltr">=EF=BB=BF <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf-8"> <meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)"> <style>@font-face { font-family: "Cambria Math"; } @font-face { font-family: Aptos; } @font-face { font-family: Menlo; } p.MsoNormal, li.MsoNormal, div.MsoNormal { margin: 0in; font-size: 10pt; fon= t-family: Aptos, sans-serif; } span.EmailStyle20 { font-family: Aptos, sans-serif; color: windowtext; } p.p1, li.p1, div.p1 { margin: 0in; font-size: 8.5pt; font-family: Menlo; col= or: rgb(56, 185, 199); } p.p2, li.p2, div.p2 { margin: 0in; font-size: 8.5pt; font-family: Menlo; col= or: black; } p.p3, li.p3, div.p3 { margin: 0in; font-size: 8.5pt; font-family: Menlo; col= or: black; } p.p4, li.p4, div.p4 { margin: 0in; font-size: 8.5pt; font-family: Menlo; col= or: rgb(202, 51, 35); } p.p5, li.p5, div.p5 { margin: 0in; font-size: 8.5pt; font-family: Menlo; col= or: rgb(57, 192, 38); } span.s1 { } span.apple-converted-space { } .MsoChpDefault { font-size: 10pt; } @page WordSection1 { size: 8.5in 11in; margin: 1in; } div.WordSection1 { page: WordSection1; }</style> <div class=3D"WordSection1"> <p class=3D"p1"><span style=3D"font-size:11.0pt;font-family:"Aptos"= ;,sans-serif;color:black">Great. Here is a diff of the proposed changes in t= hat case in ttgload.c </span><span style=3D"font-size:11.0pt;font-family:"Aptos",sans-se= rif"><br> <br> </span><span class=3D"s1">@@ -2201,7 +2201,6 @@</span><o:p></o:p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">TT_Driver </span><span class=3D"apple-converted-space"> </span><sp= an class=3D"s1">driver</span><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">=3D (TT_Driver)FT_FACE_DRIVER( glyph->face );</= span><o:p></o:p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> </span><span cla= ss=3D"s1">#endif</span><o:p></o:p></p> <p class=3D"p3"><span class=3D"apple-converted-space"> </span><o:p></o:= p></p> <p class=3D"p4"><span class=3D"s1">-</span><o:p></o:p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">if ( size->bytecode_ready > 0 )</span><= o:p></o:p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">return size->bytecode_ready;</span>= <o:p></o:p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">if ( size->bytecode_ready < 0 )</span><= o:p></o:p></p> <p class=3D"p1"><span class=3D"s1">@@ -2215,6 +2214,7 @@</span><o:p></o:p></= p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">}</span><o:p></o:p></p> <p class=3D"p3"><span class=3D"apple-converted-space"> </span><o:p></o:= p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">exec =3D size->context;</span><o:p></o:p><= /p> <p class=3D"p5"><span class=3D"s1">+</span><span class=3D"apple-converted-sp= ace"> </span> <span class=3D"s1">exec->backward_compatibility =3D 0;</span><o:p></o:p><= /p> <p class=3D"p3"><span class=3D"apple-converted-space"> </span><o:p></o:= p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> </span><span cla= ss=3D"s1">#ifdef TT_SUPPORT_SUBPIXEL_HINTING_MINIMAL</span><o:p></o:p></p> <p class=3D"p2"><span class=3D"apple-converted-space"> &n= bsp; </span><span class=3D"s1">if ( driver->interpreter_version =3D=3D TT= _INTERPRETER_VERSION_40 )</span><o:p></o:p></p> <p class=3D"MsoNormal"><span style=3D"font-size:11.0pt"><o:p> </o:p></s= pan></p> <p class=3D"MsoNormal"><br></p><div id=3D"mail-editor-reference-message-cont= ainer"><div><div><div><div> </div> </div> </div> </div> </div> </div> </div></blockquote></body></html>= --Apple-Mail-CFCACC8F-D8AC-4538-8F29-8B9DDF75C9EF--