Re: RFC: adding fd-passing to win32
Thiago Macieira <[email protected]> Tue, 09 Aug 2022 12:08:57 -0700
| Newsgroups | gmane.comp.freedesktop.dbus |
|---|---|
| Message-ID | <1869775.KyIFR8Ta78@tjmaciei-mobl5> |
On Tuesday, 9 August 2022 10:32:42 PDT Simon McVittie wrote: > On Tue, 09 Aug 2022 at 21:00:42 +0400, Marc-André Lureau wrote: > > Well, how did we introduce 'h' in the first place? It didn't exist before > > 0.13 or something. Was that so problematic, can you point me to related > > issues? > CVE-2020-12049, CVE-2014-3637, CVE-2014-3636, CVE-2014-3635, CVE-2014-3533 > and CVE-2014-3532, for a start... That was after adding the full functionality, which meant adapting the code that used it to support an extra D-Bus type. There are code generators to deal with, XML parsing, unit tests,etc. It's NOT trivial. I'm not saying it's beyond your capabilities. I actually hope you can achieve all you're setting out to do. I am however saying that reusing the 'h' type and piggy-backing on the full support that is already there should be a simpler review. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel DCAI Cloud Engineering