Re: [PATCH RESEND libgpiod v2 00/18] dbus: add GLib-based DBus daemon and command-line client
Philip Withnall <philip-Zelv8rwHIWO8qtKVGud/[email protected]> Tue, 02 Jul 2024 15:15:54 +0100
| Newsgroups | gmane.comp.freedesktop.dbus |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2024-07-02 at 16:10 +0200, Bartosz Golaszewski wrote: > On Tue, Jul 2, 2024 at 4:05=E2=80=AFPM Philip Withnall > <philip-Zelv8rwHIWO8qtKVGud/[email protected]> wrote: > >=20 > > On Fri, 2024-06-28 at 20:58 +0200, Bartosz Golaszewski wrote: > > > Resending as the emails bounced off > > > [email protected]=C2=A0due to > > > me not > > > being subscribed before. > > >=20 > > > Note: As advised by Dan Carpenter - I'm CC'ing > > > [email protected]=C2=A0to > > > get some comments on the DBus API which can be found in > > > dbus/lib/io.gpiod1.xml. > >=20 > > Do you have a copy of this branch available for comment on a git > > forge > > (GitHub/GitLab/similar)? That would make it a lot easier to leave > > comments on. D-Bus and the projects which use it have not done > > patch > > review over email for some years. > >=20 > > Philip >=20 > The branch is here: > https://github.com/brgl/libgpiod-private/tree/b4/dbus >=20 > Do I need to make a PR or can you somehow comment on the code > directly? Thanks, I can comment on the changes directly there, although I suspect the comments might get lost if you force-push changes to the branch. I=E2=80=99ll try and look over the branch in the next few days, but can mak= e no promises. Philip