Re: [PATCH RESEND libgpiod v2 00/18] dbus: add GLib-based DBus daemon and command-line client
Bartosz Golaszewski <brgl-ARrdPY/[email protected]> Wed, 10 Jul 2024 14:25:01 +0200
| Newsgroups | gmane.comp.freedesktop.dbus |
|---|---|
| Message-ID | <CAMRc=McMP8WhGOmeRU45mG3aKKwz1CTm2OFW=rVVrq=Y6vy8ew@mail.gmail.com> |
On Tue, Jul 2, 2024 at 4:15=E2=80=AFPM Philip Withnall <[email protected]= .uk> wrote: > > > > > > Do you have a copy of this branch available for comment on a git > > > forge > > > (GitHub/GitLab/similar)? That would make it a lot easier to leave > > > comments on. D-Bus and the projects which use it have not done > > > patch > > > review over email for some years. > > > > > > Philip > > > > The branch is here: > > https://github.com/brgl/libgpiod-private/tree/b4/dbus > > > > Do I need to make a PR or can you somehow comment on the code > > directly? > > Thanks, I can comment on the changes directly there, although I suspect > the comments might get lost if you force-push changes to the branch. > > I=E2=80=99ll try and look over the branch in the next few days, but can m= ake no > promises. > > Philip Thanks a lot for the thorough review! I'll address your points in v3. Bartosz