approval_X11R6.8.x requested: [Bug 1383] X failed to scan PCI bus on ia64/460gx due to typo : [Attachment 902] xorg-x11-6.8.0-ia64-460gx-pci-typo.patch
| Newsgroups | gmane.comp.freedesktop.release-wranglers |
|---|---|
| Message-ID | <[email protected]> |
Kristian Høgsberg <krh-1OA22m9ORUweIZ0/[email protected]> has asked for approval_X11R6.8.x: Bug 1383: X failed to scan PCI bus on ia64/460gx due to typo https://bugs.freedesktop.org/show_bug.cgi?id=1383 Attachment 902: xorg-x11-6.8.0-ia64-460gx-pci-typo.patch https://bugs.freedesktop.org/attachment.cgi?id=902&action=edit ------- Additional Comments from Kristian Høgsberg <krh-1OA22m9ORUweIZ0/[email protected]> Sorry for the late nomination, I was going through our RPM today and found this. The patch is a bit tricky, because 1) this code uses assignments in if conditionals in other places and 2) there are extra ( ) around the assignment as if to silence the warning. However, looking at the context, it's clear that the patch doesn't break anything, since just below the if statement there is code dereferencing pBusInfo, but if this code is reached pBusInfo would be NULL. We have this patch in our RPM.