Re: [PATCH 1/2] Don't declare xcb_req as static

Eric Anholt <[email protected]> Wed, 28 Jun 2017 10:08:42 -0700

Newsgroups	gmane.comp.freedesktop.xcb
Message-ID	<[email protected]>

Adam Jackson <[email protected]> writes:

> Doing so forces the compiler to allocate storage for the symbol in
> .data, which means 24 bytes of dirty data and a relocation per request
> function.
>
>    text	   data	    bss	    dec	    hex	filename
>   88888	   7136	      8	  96032	  17720	src/.libs/libxcb-glx.so.before
>   92432	    680	      8	  93120	  16bc0	src/.libs/libxcb-glx.so.after

Increasing the executed-code size by 4% here makes me nervous -- done
any performance comparison before and after?  I think that delta will
get buried under the overhead of xcb_send_request, but it would be nice
to be sure.

Is the problem just the relocations in that data?  Would pulling the
req->ext out of xcb_protocol_request and passing it as another parameter
of a new xcb_send_request variant also fix it, while letting us keep the
remainder of the xcb_protocol_request_t static?

_______________________________________________
Xcb mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/xcb

signature.asc (application/pgp-signature, 832 B)