Re: [PATCH libxcb v2 3/4] c_client: Add support for lists of FDs

Hi Eric,

On 17 June 2017 at 02:11, Eric Anholt <[email protected]> wrote:
> Daniel Stone <[email protected]> writes:
>> Matching xcbgen changes, add support having a ListType which contains
>> file descriptors. Use this to send a variable number of FDs to the
>> server, including when the list size is not fixed.
>
> I've verified that patch 1 and 2 don't change the generated code, that
> this patch only cosmetically changes the code, and that the generated
> code for patch 4 looks reasonable.
>
> I find the python to be pretty hairy, but it seems fine, and it's really
> the generated code that matters, so patch 1-3 are:
>
> Reviewed-by: Eric Anholt <[email protected]>

Thanks for the review! FWIW, I find the Python quite hairy as well,
but after a couple of attempted reworks, couldn't find anything which
worked better.

Uli, would you be OK pushing these first 3 support patches, or would
you prefer I did, or ... ?

Cheers,
Daniel
_______________________________________________
Xcb mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/xcb