Re: [PATCH libxcb v2 3/4] c_client: Add support for lists of FDs

Hi Uli,

On 22 July 2017 at 12:12, Uli Schlachter <[email protected]> wrote:
> On 20.07.2017 19:15, Daniel Stone wrote:
>> On 17 June 2017 at 02:11, Eric Anholt <[email protected]> wrote:
>>> I've verified that patch 1 and 2 don't change the generated code, that
>>> this patch only cosmetically changes the code, and that the generated
>>> code for patch 4 looks reasonable.
>>>
>>> I find the python to be pretty hairy, but it seems fine, and it's really
>>> the generated code that matters, so patch 1-3 are:
>>>
>>> Reviewed-by: Eric Anholt <[email protected]>
>>
>> Thanks for the review! FWIW, I find the Python quite hairy as well,
>> but after a couple of attempted reworks, couldn't find anything which
>> worked better.
>>
>> Uli, would you be OK pushing these first 3 support patches, or would
>> you prefer I did, or ... ?
>
> I'd think that it is less work overall if you push them since you
> already have them in Git. Also, I usually try to stay away from the
> Python code around XCB. :-)
>
> So, feel free to push them.

Thanks a lot! I've pushed both sets of preparatory patches now, so
there's just the actual DRI3 protocol pending.

To ssh://git.freedesktop.org/git/xcb/proto
   1c05de5..9df4ead  9df4eadb482be083c66c856e9c7f38331d50a2b4 -> master

To ssh://git.freedesktop.org/git/xcb/libxcb
   d10194a..a3e9821  master -> master

Cheers,
Daniel
_______________________________________________
Xcb mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/xcb