Re: Xmd.h in c99 form

Egbert Eich <[email protected]> Mon, 16 Feb 2004 10:04:06 +0100
Newsgroups gmane.comp.freedesktop.xlibs.general
Message-ID <[email protected]>
Jim Gettys writes:
 > Yeah, the history is that the system definitions didn't exist
 > in the 1980's for 16/32 bit things.  So we had to roll our
 > own.
 > 
 > The question is whether there are still systems who build
 > X who don't have the stdint.h file or not, and/or whether by
 > providing such a file, we could then do this clean up.
 > 
 > Anyone have an opinion?

Why not move these things to a separate file?

Then you have two options, either:

#ifdef NO_STDIN
# include "Xstdin.h"
#else
# include <stdint.h>
#endif

and add -DNO_STDIN

or do

#include @STDIN_H@

in a Xmd.h.in. I'd perfer solution #1 as one immediately understands
the issue from looking at the code. Adding an -DNO_STDIN to the
compiler flags shouldn't be more difficult than creating an xmd.h from
an .in file.
Furthermore I'd suggest to be a little careful on getting rid of things
like cvtINT.*to.* or NEXTPTR(). These things are removed quickly but
may leave some very unhappy people behind.
Is there a need for deleting this stuff?

Egbert.



Egbert.