Commit - Fix to allow scaling and rotation to correctly occur at same time
"Defnet, Benjamin R" <[email protected]> Tue, 12 May 2009 17:05:34 -0700
| Newsgroups | gmane.comp.freedesktop.xserver.cvs |
|---|---|
| Message-ID | <D2090E375276764B96AA3E46B35569CB413E5631@orsmsx501.amr.corp.intel.com> |
--_004_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_
Content-Type: multipart/alternative;
boundary="_000_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_"
--_000_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Matrix multiply done in wrong order when applying transform matrix (scaling=
) to rotation matrix. This fix allows rotation and scaling to correctly oc=
cur at the same time.
This is my first time submitting a patch so please let me know if I'm not d=
oing this right.
See attached patch
Ben Defnet
--_000_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_
Content-Type: text/html; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc=
hemas-microsoft-com:office:word" xmlns=3D"http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=3DContent-Type content=3D"text/html; charset=3Dus-ascii">
<meta name=3DGenerator content=3D"Microsoft Word 11 (filtered medium)">
<style>
<!--
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:Arial;
color:windowtext;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=3DEN-US link=3Dblue vlink=3Dpurple>
<div class=3DSection1>
<p class=3DMsoNormal style=3D'text-autospace:none'><font size=3D2 face=3D"C=
ourier New"><span
style=3D'font-size:10.0pt;font-family:"Courier New"'>Matrix multiply done i=
n
wrong order when applying transform matrix (scaling) to rotation matrix.&nb=
sp;
This fix allows rotation and scaling to correctly occur at the same time.<o=
:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span style=3D'font-size:1=
0.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span style=3D'font-size:1=
0.0pt;
font-family:Arial'>This is my first time submitting a patch so please let m=
e
know if I’m not doing this right.<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span style=3D'font-size:1=
0.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span style=3D'font-size:1=
0.0pt;
font-family:Arial'>See attached patch<o:p></o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span style=3D'font-size:1=
0.0pt;
font-family:Arial'><o:p> </o:p></span></font></p>
<p class=3DMsoNormal><font size=3D2 face=3DArial><span style=3D'font-size:1=
0.0pt;
font-family:Arial'>Ben Defnet<o:p></o:p></span></font></p>
</div>
</body>
</html>
--_000_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_--
--_004_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_
Content-Type: application/octet-stream;
name="0001-Matrix-mulitply-done-in-wrong-order-when-applying-tr.patch"
Content-Description: 0001-Matrix-mulitply-done-in-wrong-order-when-applying-tr.patch
Content-Disposition: attachment;
filename="0001-Matrix-mulitply-done-in-wrong-order-when-applying-tr.patch";
size=1345; creation-date="Tue, 12 May 2009 16:53:39 GMT";
modification-date="Tue, 12 May 2009 16:53:39 GMT"
Content-Transfer-Encoding: base64
RnJvbSBjN2NiYjhhMTllMmM2ZDI5YzhhMWE4YTIzYjUzN2NiZmNmMjI3NGQxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBEZWZuZXQgPGJlbmphbWluLnIuZGVmbmV0QGlu
dGVsLmNvbT4KRGF0ZTogVHVlLCAxMiBNYXkgMjAwOSAxNjo0Nzo0MyAtMDcwMApTdWJqZWN0OiBb
UEFUQ0hdIE1hdHJpeCBtdWxpdHBseSBkb25lIGluIHdyb25nIG9yZGVyIHdoZW4gYXBwbHlpbmcg
dHJhbnNmb3JtIG1hdHJpeAogKHNjYWxpbmcpIHRvIHJvdGF0aW9uIG1hdHJpeC4gIFRoaXMgZml4
IGFsbG93cyByb3RhdGlvbiBhbmQgc2NhbGluZwogdG8gY29ycmVjdGx5IG9jY3VyIGF0IHRoZSBz
YW1lIHRpbWUuCiBTaWduZWQtb2ZmLWJ5OiBCZW5qYW1pbiBEZWZuZXQgPGJlbmphbWluLnIuZGVm
bmV0QGludGVsLmNvbT4KCgltb2RpZmllZDogICBycnRyYW5zZm9ybS5jCi0tLQogcmFuZHIvcnJ0
cmFuc2Zvcm0uYyB8ICAgIDYgKysrLS0tCiAxIGZpbGVzIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygr
KSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9yYW5kci9ycnRyYW5zZm9ybS5jIGIvcmFu
ZHIvcnJ0cmFuc2Zvcm0uYwppbmRleCA4YmRmZjVhLi4yMjllODJkIDEwMDY0NAotLS0gYS9yYW5k
ci9ycnRyYW5zZm9ybS5jCisrKyBiL3JhbmRyL3JydHJhbnNmb3JtLmMKQEAgLTI1MSwxMCArMjUx
LDEwIEBAIFJSVHJhbnNmb3JtQ29tcHV0ZSAoaW50CQkJICAgIHgsCiAjaWZkZWYgUkFORFJfMTJf
SU5URVJGQUNFCiAgICAgaWYgKHJyX3RyYW5zZm9ybSkKICAgICB7Ci0gICAgICAgIGlmICghcGl4
bWFuX3RyYW5zZm9ybV9tdWx0aXBseSAodHJhbnNmb3JtLCB0cmFuc2Zvcm0sICZycl90cmFuc2Zv
cm0tPnRyYW5zZm9ybSkpCisJaWYgKCFwaXhtYW5fdHJhbnNmb3JtX211bHRpcGx5ICh0cmFuc2Zv
cm0sICZycl90cmFuc2Zvcm0tPnRyYW5zZm9ybSwgdHJhbnNmb3JtKSkKIAkgICAgb3ZlcmZsb3cg
PSBUUlVFOwotCXBpeG1hbl9mX3RyYW5zZm9ybV9tdWx0aXBseSAoZl90cmFuc2Zvcm0sIGZfdHJh
bnNmb3JtLCAmcnJfdHJhbnNmb3JtLT5mX3RyYW5zZm9ybSk7Ci0JcGl4bWFuX2ZfdHJhbnNmb3Jt
X211bHRpcGx5IChmX2ludmVyc2UsICZycl90cmFuc2Zvcm0tPmZfaW52ZXJzZSwgZl9pbnZlcnNl
KTsKKwlwaXhtYW5fZl90cmFuc2Zvcm1fbXVsdGlwbHkgKGZfdHJhbnNmb3JtLCAmcnJfdHJhbnNm
b3JtLT5mX3RyYW5zZm9ybSwgZl90cmFuc2Zvcm0pOworCXBpeG1hbl9mX3RyYW5zZm9ybV9tdWx0
aXBseSAoZl9pbnZlcnNlLCBmX2ludmVyc2UsICZycl90cmFuc2Zvcm0tPmZfaW52ZXJzZSk7CiAg
ICAgfQogI2VuZGlmCiAgICAgLyoKLS0gCjEuNi4wLjYKCg==
--_004_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
xserver-commit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xserver-commit
--_004_D2090E375276764B96AA3E46B35569CB413E5631orsmsx501amrcor_--