Re: [xserver-commit] xserver/hw/kdrive/ati ati.c,1.1,1.2 ati_draw.c,1.1,1.2

On Wed, 2003-11-19 at 16:05, Eric Anholt wrote:
> Committed by: anholt
> 
> Update of /cvs/xserver/xserver/hw/kdrive/ati
> In directory pdx:/home/anholt/xserver/hw/kdrive/ati
> 
> Modified Files:
> 	ati.c ati_draw.c 
> Log Message:
> - Fix confusion of depth/bitsPerPixel in ati_draw.c
> - Disable acceleration with 24bpp due to apparent broken acceleration.
>   Accel at 24bpp was the cause of the crashes when people tried to use
>   any depth over 16.  XFree86 doesn't support 24 either.
> - Disable at < 8bpp, too.
> - Add the other Rage 128 PCI IDs.
> - Remove unnecessary setting of scissor registers (only default
>   scissor gets used).

This should fix some of the issues people were having with Xati. 
Unfortunately, probably due to vesa (according to keithp), depth 24 uses
24 bits per pixel, and depth 32 isn't supported and drops to depth 24. 
This means that there's no accel for depth greater than 16.  The depth 4
that seems to get chosen for some reason (we should choose a sane
default -- 16 perhaps? :-) results in a segfault of the server.  Depth
8, which I didn't disable accel for, has bad colors.

-- 
Eric Anholt                                [email protected]          
http://people.freebsd.org/~anholt/         [email protected]