Re: detail listener is broken in the 3.2.9 release
Alan DeKok via Freeradius-Users <[email protected]> Tue, 2 Jun 2026 09:43:47 -0400
| Newsgroups | gmane.comp.freeradius.user |
|---|---|
| Message-ID | <[email protected]> |
--===============8822434226813072568== Content-Type: multipart/signed; boundary="Apple-Mail=_558811C3-B3A8-444C-8B81-0436CF337B8C"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Apple-Mail=_558811C3-B3A8-444C-8B81-0436CF337B8C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Thanks. We'll pull in the patch. And then figure out what we want to = do with an updated release. I thought we had tests for the detail file reader. But I'll = double-check. > On Jun 2, 2026, at 9:06=E2=80=AFAM, Bj=C3=B8rn Mork via = Freeradius-Users <[email protected]> wrote: >=20 > I bisected it down to > = https://github.com/FreeRADIUS/freeradius-server/commit/5691cbc615e515490fc= 490965baff58236d64cd3 >=20 > It didn't revert cleanly so I looked a bit closer and noticed that it > ends up changing >=20 > if (!request->packet->vps) { > .. > } else { > rcode =3D 0; > } > .. > return 1; >=20 > into a more direct >=20 > if (request->packet->vps) return 0; >=20 >=20 > The problem is obviously that the return value changes from 1 to 0. > Simple fix ready for pulling at > https://github.com/FreeRADIUS/freeradius-server/pull/5870 >=20 >=20 > (yes, I found this and verified the fix in a real world installation) >=20 >=20 > Bj=C3=B8rn > - > List info/subscribe/unsubscribe? See = http://www.freeradius.org/list/users.html --Apple-Mail=_558811C3-B3A8-444C-8B81-0436CF337B8C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEIUl02elqcIsf1zM0v3SJ0h7dTTMFAmoe3hMACgkQv3SJ0h7d TTNz9Q//c4b28I5WjLL7HzOfrkS7Xy+w8+xzAi9W2t4IQhkOhvQNLbqOzl1vT/dH 1SYPI/o/gH4bVb772OTBB1yU9qI/VKDdMgaS3YGVjwfJoI/vC47R4w/GyULG20qv AViJCAwQ+FwKmZ7RSKXrUJz8xXz4m5qLRR2CYDTm3KCSKgOn7Zq3dl6AaEy7DSNW QbHxvqr7qlbCqLNRWrF2lMYetyTfU5b+vvKfUs58LMIMWO3sZpjo1ZKK4Z0tb8Cu wTi6cSKyWRgtweImkx2uDuSYnp8xiq5bmoX2SyQVOcFIeUAjMv+ODrNT/Lo/FmP/ oDIWuL1yFtd+9E8vv6qw29SnEY5gCVKCvC/h5TDDjDhLR+Rf1e8HQ9hLb5W1PcXH gVyctREWEP8kDLF8+ae+7Ilb5ZBKFhf8IZKUKythYcwHtBvNTsmoekXnwJ+yj+1+ 22o2FF1NcndTmAdh5QBd81tjCG/7pNqljNmEtObq24xn3T8JtdO9fak6cVL6fGJ8 hdC6naQ6HNr/DdLsEMRpdm4ze2yBshjvfXEpIRneVJaNaZAtXPmwIchYkLcMB5Bl 93tCgens1j3RmQ4eJnkswAgrqs4YThYVyIVpeBVcwb4mmB449Pwj77EmxycNnyYL AMcnW6FJoWeEG+8nWtuUc6Lk75iN/R+QsHRUcCzd/4PCHvrPoC8= =i35n -----END PGP SIGNATURE----- --Apple-Mail=_558811C3-B3A8-444C-8B81-0436CF337B8C-- --===============8822434226813072568== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html --===============8822434226813072568==--