Re: history patch
stefan-FSQMiLcnEBujv7OD/[email protected]
| Newsgroups | gmane.comp.games.mud.client.lyntin |
|---|---|
| Message-ID | <[email protected]> |
My patch "shortend" (or is this written shortened, or not like his at all? sorry, english is not my native language ;) the history by removing entries that were identical to the one typed before. I am proposing that the identical history entries are not removed when they are inserted into the list (as does my patch) but supressed when the history is requested. so user types: asdf qwer asdf asdf asdf self._history contains all the above. If the corresponding config is set, the history that the users gets when requesting it (e.g. by typing <up> in the ui) looks like asdf qwer asdf hope this is more clear (if not ask :) Stefan Quoting will guaraldi <[email protected]>: > > I'm not following this. What are you suggesting? What's "shortened" > history? > > > On Wed, 12 Nov 2003 stefan-FSQMiLcnEBujv7OD/[email protected] wrote: > > > > I just had another idea how the "shortened" history could be > implemented. > > The history is stored completely (as it is done now), but the output > can > > be shortened if the uers wants to (by a #config). With that solution, > the > > two operation modes are not mutually exclusive but can coexist. > > > > Stefan > > > > Quoting will guaraldi <[email protected]>: > > > > > > > > You sure about that? Looks like it uses the history manager's > history > > > buffer to me. I'll test it when I get home, but I think it's > working > > > fine. What makes you say the tkui isn't using the history manager > > > history > > > buffer? > > > > > > > > > On Tue, 11 Nov 2003, S.Aeschbacher wrote: > > > > > > > > thats ok for me :) > > > > > > > > BTW the tk ui does not seem to use this history, is this > intentional? > > > > > > > > regards > > > > > > > > Stefan > > > > > > > > > > > > On Tue, Nov 11, 2003 at 11:03:50AM -0600, will guaraldi wrote: > > > > > > > > > > People have mentioned before on the list that they want the > exact > > > history. > > > > > So this patch wouldn't work for them. > > > > > > > > > > I'll make it configurable, though, from the #config command. > > > > > > > > > > On Tue, 11 Nov 2003, S.Aeschbacher wrote: > > > > > > > > > > > Hi > > > > > > how about this minor modification to history.py? > > > > > > In my eyes it does not make much sense storing repeatedly the > > > > > > same string in the history (It just slows down history > browsing). > > > > > > > > > > > > > > > > > > --- history.py.old Tue Nov 11 17:36:41 2003 > > > > > > +++ history.py Tue Nov 11 17:35:42 2003 > > > > > > @@ -83,6 +83,9 @@ > > > > > > if not input: > > > > > > return > > > > > > > > > > > > + if input == self._history[0]: > > > > > > + return > > > > > > + > > > > > > self._history.insert(0, input) > > > > > > if len(self._history) > 1000: > > > > > > del self._history[-1] > > > > > > > > > > > > regards > > > > > > > > > > > > Stefan > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > > This SF.Net email sponsored by: ApacheCon 2003, > > > > > > 16-19 November in Las Vegas. Learn firsthand the latest > > > > > > developments in Apache, PHP, Perl, XML, Java, MySQL, > > > > > > WebDAV, and more! http://www.apachecon.com/ > > > > > > _______________________________________________ > > > > > > Lyntin-devl mailing list > > > > > > [email protected] > > > > > > https://lists.sourceforge.net/lists/listinfo/lyntin-devl > > > > > > > > > > > > > > > > -- > > > > > whatever it is, you can find it at > http://www.bluesock.org/~willg/ > > > > > except Will--you can only see him in real life. > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.Net email sponsored by: ApacheCon 2003, > > > > 16-19 November in Las Vegas. Learn firsthand the latest > > > > developments in Apache, PHP, Perl, XML, Java, MySQL, > > > > WebDAV, and more! http://www.apachecon.com/ > > > > _______________________________________________ > > > > Lyntin-devl mailing list > > > > [email protected] > > > > https://lists.sourceforge.net/lists/listinfo/lyntin-devl > > > > > > > > > > -- > > > whatever it is, you can find it at http://www.bluesock.org/~willg/ > > > except Will--you can only see him in real life. > > > > > > > > > > > -- > whatever it is, you can find it at http://www.bluesock.org/~willg/ > except Will--you can only see him in real life. >