Re: snoop setting doesnt seem to work (SOLVED)

On Mon, 2004-12-13 at 14:06, David Clymer wrote:
> On Mon, 2004-12-13 at 13:07, will guaraldi wrote:
> > Oops--don't use the #snoop command.  Instead, use the #config command to 
> > set the "snoopdefault" (global) or the "snoop" (session) configuration 
> > properties.
> 
> I've got these set (as shown in my config dump in the orig. email) to
> off, but they have no effect.
> 
> > 
> > The #snoop command should be removed.  At least, that's my first-blush 
> > guess as to what the issue is.  I haven't looked at this code in months.
> > 
> 
> That may be, but I dont think the snoop command itself is the problem,
> since the snooping stays on regardless of what I do with #snoop. It's
> probably just a tangential thing.
> 

showTextForSession() in base.py was always returning 1. It was deciding
to show text if the session in question did not have a _snoop attribute.
Well, it seems that _no_ session ever has a _snoop attribute, and thus
text for every session was being shown.

diff is below.

-davidc

*** base.py.old 2004-12-16 23:43:32.000000000 -0500
--- base.py     2004-12-16 23:42:37.000000000 -0500
***************
*** 130,136 ****
      @returns: 1 if we should show text, 0 if not
      @rtype: boolean
      """
!     if ses == None or getattr(ses, "_snoop", None) == None \
          or exported.get_current_session() == ses \
          or exported.get_config("snoop", ses, 1) == 1:
        return 1
--- 130,136 ----
      @returns: 1 if we should show text, 0 if not
      @rtype: boolean
      """
!     if ses == None \
          or exported.get_current_session() == ses \
          or exported.get_config("snoop", ses, 1) == 1:
        return 1




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/