Re: Starting patch review wiki

On Wed, Feb 25, 2026 at 12:39 AM Kyrylo Tkachov via Gcc <[email protected]> wrote:
>
> Hi all,
>
> I gave a talk at last Cauldron in Porto about starting upstream patch review and addressing some common issues that potential new reviewers face. I was asked to put the content together on a wiki page. Apologies for the delay, but I’ve done that now at:
> https://gcc.gnu.org/wiki/StartingPatchReview
> It should be visible from the wiki home page too.
> Feel free to extend it with more review guidance or correct things that you think are wrong.

I added some recommendations on what to recommend for new developers
to run to get either the commit message correct and/or coding style
correct.
Obviously for the forge submissions these 2 are run after granting
approval but for email patch review it would help to recommend them
for new developers.
It should be noted that ./contrib/check_GNU_style.py needs some more
improvements in some areas as it is errors out in some cases that it
should not (I filed 3 bugs yesterday I noticed while reviewing the
ouput from the new backend for wasm) but I think we should still
recommend it.

Thanks,
Andrea


>
> Thanks,
> Kyrill