Re: Please ensure Signed-off-by and similar trailers are hyphenated
Christophe Lyon <[email protected]> Mon, 15 Jun 2026 16:18:29 +0200
| Newsgroups | gmane.comp.gcc.rust,gmane.comp.gcc.devel,gmane.comp.gcc.fortran,gmane.comp.gcc.libstdc++.devel |
|---|---|
| Message-ID | <[email protected]> |
On 6/15/26 15:46, Jonathan Wakely via Gcc wrote: > https://git-scm.com/docs/git-interpret-trailers says: > > When reading trailers, there can be no whitespace before or inside the > <key>, but any number of regular space and tab characters are allowed > between the <key> and the separator. There can be whitespaces before, > inside or after the <value>. The <value> may be split over multiple > lines with each subsequent line starting with at least one whitespace, > like the "folding" in RFC 822. > > Formatting these Git trailers correctly ensures they can be used with > git-interpret-trailers and found with a simple 'git log --grep' query, > without having to match a mix of correct and incorrect forms using a > regex. This is especially important for Signed-off-by: because the > DCO sign-off is legally significant and it makes things harder to > check if you use the wrong form of the tag. > > Please ensure that all trailers in Git commit messages are hyphenated, > e.g. "Co-authored-by:" not "Co-authored by:", and especially not > "Signed off by:" Is this something we can / want to add to contrib/gcc-changelog/git_check_commit.py ? Thanks, Christophe