Re: [PATCH 13/13] Coarray shared memory library
Tobias Burnus <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
Am 11.02.26 um 09:02 schrieb Richard Biener: > On Tue, 10 Feb 2026, Jerry D wrote: > Dear all, as requested, > > See attached patch 13 of 13 > > So libcaf_shared will be installed as static library only, similar > to libcaf_single. The libgfortran ABI does not seem to be affected. > > The only concern from my side would be failing builds, but those > should be quickly addressed and avoided by wider testing pre-merge. Glancing through the patches, my impression is that the library (→ 5/13) unconditionally uses 'pthread.h'. Thus, it seems to make sense to add a pthread check similar to libgomp and only enable the library if it is available. (I also wonder whether there should be a libcafshmem.spec file which adds -pthread or -lpthread as needed, cf. libgomp's configure.ac and libgomp.spec). [The 13/13 patch seems to build the library unconditionally.] Tobias