Re: [PATCH 1/13] Coarray shared memory library

Tobias Burnus <[email protected]>
Newsgroups gmane.comp.gcc.patches,gmane.comp.gcc.fortran
Message-ID <[email protected]>
Jerry D wrote:
>      Fortran: Unify check of teams parameter in failed/stopped_images().

This patch looks good to me.

A 'sorry' is replaced by a data-type check [in the testcases: for invalid
args]. Actually, the value was already passed on to the library, except
that single didn't use it (obviously). No idea about OpenCoarrays;
for libcaf_shmmem, it will be used.

>      
>      gcc/fortran/ChangeLog:
>      
>              * check.cc (gfc_check_failed_or_stopped_images): Support teams
>              argument and check for incorrect type.
>      
>      gcc/testsuite/ChangeLog:
>      
>              * gfortran.dg/coarray/failed_images_1.f08: Adapt check of error
>              message.
>              * gfortran.dg/coarray/stopped_images_1.f08: Same.

Thanks,

Tobias
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.