Re: [PATCH 3/13] Coarray shared memory library

On 2/11/26 5:40 AM, Tobias Burnus wrote:
> Jerry D wrote:
> 
>>      Fortran: Fix coarray generation for char arrays and derived types.
>>      Fix the generation of a coarray, esp. its bounds, for char arrays.
>>      When a scalar char array is used in a co_reduce the coarray part was
>>      dropped.
>>      Furthermore for class typed dummy arguments where derived types were
>>      used as actual arguments the coarray generation is now done, too.
> 
> Common theme in this thread – there is no testcase for it. The only newly
> added patches except for the very fews bundled with changes are 6/13's
>              * gfortran.dg/coarray/co_reduce_string.f90: New test.
>              * gfortran.dg/coarray/sync_team.f90: New test.

I will scan through here and verify all test cases are where they need to be.

Thank you Tobias for all of your comments.

Also note that I am incorporating the -m32 fixes here and will not it in the 
commit log.

Regards,

Jerry
> 
> Thus, can someone create patches for the changes of this patch?Otherwise, the 
> patch LGTM.
> 
>>      gcc/fortran/ChangeLog:
>>              * trans-expr.cc (get_scalar_to_descriptor_type): Fix coarray
>>              generation.
>>              (copy_coarray_desc_part): New function to copy coarray dimensions.
>>              (gfc_class_array_data_assign): Use the new function.
>>              (gfc_conv_derived_to_class): Same.
> 
> Tobias
>