Re: [PATCH v3] Fortran: Fix diagnostic for ambiguous pointer function assignment [PR80012]
Harald Anlauf <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
Hi Gonzalo, On 2/21/26 13:16, Gonzalo Silvalde Blanco wrote: > Hi Harald, > > So I have to add an entry to gcc/fortran/ChangeLog? This is related with > the CI error notification? Sorry for the silly questions but as I said > before is my first contribution to GCC. I was assuming this to be the case, so I tried to help here. The information was contained in your mails, from which I manually reconstructed the commit message, c.f. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80012#c10 (I personally find it cumbersome to work with patches inlined in mails instead of attached, and would hope that we could also offer a process where people can provide merge/pull requests, and maybe even CI pipelines for regression tests.) You might go back to your patch and run a regression test yourself (make check-fortran) in the build directory to see if there are failures after your changes. (I did some random local tests which did not make me suspicious, but I do not have the resources to do full regression tests for patches by contributors other than my own. Admittedly, I have zero experience with the new diagnostics framework and do hope that others will be able to explain what went wrong here.) Best, Harald > Thanks for all your patience, > Gonzalo > > El 21/2/26 a las 8:30, Harald Anlauf escribió: >> On 2/21/26 01:24, Steve Kargl wrote: >>> On Fri, Feb 20, 2026 at 08:42:28PM +0100, Harald Anlauf wrote: >>>> Dear all, >>>> >>>> since Gonzalo asked my off-list to do the honors, I pushed his patch >>>> for >>>> him as r16-7604-g84ef4948609260 . >>>> >>> >>> PS: There appears to be a missing gcc/fortran/ChangeLog entry. >>> >> >> I just reverted the commit by r16-7607-gd4893480373dee . >> >> Harald >> >