Re: [Fortran, PR124484, v3] Fix testing caf_shmem on older glibcs was: [Linaro-TCWG-CI] gcc-16-7727-gaa09298cb017: 157 regressions on aarch64

Hi Jakub,

thanks for the quick review.

I have commit as gcc-16-8081-g5cd67ad86920

with the changelog changed to:

    Fortran: Fix caf-tests on older glibcs [PR124484]
    
    gcc/testsuite/ChangeLog:
    
            PR testsuite/124484
            * gfortran.dg/coarray/caf.exp: Add -pthread and -lrt
            for *-linux* targets for caf_shmem testing.

Regards,
	Andre

On Fri, 13 Mar 2026 16:31:20 +0100
Jakub Jelinek <[email protected]> wrote:

> On Fri, Mar 13, 2026 at 04:25:37PM +0100, Andre Vehreschild wrote:
> > Andre Vehreschild * Email: vehre ad gmx dot de   
> 
> > >From ed6f79a7c238608ad9900826d8ee33d4bd13b586 Mon Sep 17 00:00:00 2001  
> > From: Andre Vehreschild <[email protected]>
> > Date: Fri, 13 Mar 2026 12:24:41 +0100
> > Subject: [PATCH] Fortran: Fix caf-tests on older glibcs [PR124484]
> > 
> > gcc/testsuite/ChangeLog:
> > 
> > 	PR Fortran/124484
> > 	* gfortran.dg/coarray/caf.exp: Add -pthread and -lrt for
> > 	*-linux* targets for caf_shmem testing.  
> 
> I think the pre-commit hook will reject the above, maybe you need
> to move the for word from the first line to the start of second,
> as it might be unhappy the line starts with tab * but isn't followed by
> space.
> 
> Otherwise LGTM.
> 
> > --- a/gcc/testsuite/gfortran.dg/coarray/caf.exp
> > +++ b/gcc/testsuite/gfortran.dg/coarray/caf.exp
> > @@ -123,7 +123,11 @@ foreach test [lsort [glob -nocomplain
> > $srcdir/$subdir/*.\[fF\]{,90,95,03,08} ]] if { [istarget *-*-freebsd*] } {
> >                  dg-test $test "-fcoarray=lib -pthread $flags -lcaf_shmem"
> > {} } else {
> > -                dg-test $test "-fcoarray=lib $flags -lcaf_shmem" {}
> > +                if { [istarget *-linux*] } {
> > +                    dg-test $test "-fcoarray=lib -pthread $flags
> > -lcaf_shmem -lrt" {}
> > +                } else {
> > +                    dg-test $test "-fcoarray=lib $flags -lcaf_shmem" {}
> > +                }
> >              }
> >              cleanup-modules ""
> >          }
> > -- 
> > 2.53.0
> >   
> 
> 
> 	Jakub
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de