Re: [PATCH][regression][OpenMP][PR120286] Double free detected when using openmp

Hi all,

first, I have to admit that I didn't see a review of this patch – but 
also no indication that Jerry planned to push that patch by Christopher, 
which I find confusing.

In any case, there is an issue with where the testcase is placed:

* OpenMP compile tests should be placed to 
gcc/testsuite/gfortran.dg/gomp/ - which automatically also adds the 
-fopenmp flag

* OpenMP link and runtime tests – and all files that include omp_lib.h 
or 'use omp_lib' need to go to libgomp/testsuite/libgomp.fortran/ as 
neither the module nor libgomp.so is available for tests in gcc/testsuite/.

* * *

Jerry D wrote:
>     PR fortran/120286
>     * gfortran.dg/pr120286.f90: New test.
> Signed-off-by: Christopher Albert <[email protected]>

Can you move that test to libgomp/testsuite/ – as it is 'dg-do run'; the 
'dg-additional-options "-fopenmp"' can be then also be removed.

* * *

Regarding patch reviews: I know that I am way behind reviewing patches :-(

Tobias