Re: [PATCH][regression][OpenMP][PR120286] Double free detected when using openmp
Jerry D <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
On 3/17/26 9:44 AM, Tobias Burnus wrote: > Hi Jerry, > > Jerry D: >>>> Is there any specific way to invoke the testsuite other that make check- >>>> fortran? > > BTW: Regarding the gcc/testsuite/ vs. libgomp/testsuite – and only > the latter supporting omp_lib and linking libgomp. > > Putting such tests into gcc/testsuite/*/gomp/ happens quite > often, also because depending on how you test and what GCC > your system has installed, it will just PASS - albeit typically > by using /usr/lib64/libgomp.so instead of the just build one. > > Thus, while it is better to put it into the right spot from the > beginning, you are not the first nor will you be the last who > does so. - And I am sure that it will happen to me (again) in > the future ... > > > Thanks again for taking care of this patch in particular and > about Christopher's patches - and sorry for being not faster > in reviewing. > > > I wrote those email mainly to (a) get the FAILs fixed that some see > and (b) to provide some background as I think Christopher has > some more pending patches. > > Tobias > Yes I understand. I plan to commit the following. I tested this using make -k -j10 check-target-libgomp-fortran and it tested good. It took we a couple of times to get the 'git gcc-verify' happy enough. Best regards, Jerry commit f41a867ac51ba76e78859c4be755041a94c0a29e (HEAD -> master) Author: Jerry DeLisle <[email protected]> Date: Tue Mar 17 11:09:12 2026 -0700 fortran: Delete pr120286.f90 from gfortran testsuite. [PR120286] PR fortran/120286 gcc/testsuite/ChangeLog: * gfortran.dg/pr120286.f90: Removed. libgomp/ChangeLog: * testsuite/libgomp.fortran/pr120286.f90: New test. diff --git a/gcc/testsuite/gfortran.dg/pr120286.f90 b/libgomp/testsuite/libgomp.fortran/pr120286.f90 similarity index 96% rename from gcc/testsuite/gfortran.dg/pr120286.f90 rename to libgomp/testsuite/libgomp.fortran/pr120286.f90 index 99c02a78c9c..e45ed5539a6 100644 --- a/gcc/testsuite/gfortran.dg/pr120286.f90 +++ b/libgomp/testsuite/libgomp.fortran/pr120286.f90 @@ -1,5 +1,4 @@ ! { dg-do run } -! { dg-additional-options "-fopenmp" } ! ! PR fortran/120286 - scalar class pointers in OpenMP private/firstprivate ! clauses must preserve association status without taking ownership.