Re: [Patch, fortran] PR115315 - [PDT] valgrind error in gfc_simplify_expr

Hi Paul,

Am 19.03.26 um 11:26 AM schrieb Paul Richard Thomas:
> Hello All,
> 
> This looks to be a regression in that the error emitted by all current
> versions of gfortran:
> 
> rm: cannot remove '*.original': No such file or directory
> pr115315.f90:21:25:
> 
>     21 |     integer :: c2(iachar('ABCDEFGHIJ'(n1:n1)))
>        |                         1
> Error: Argument of IACHAR at (1) must be of length one
> pr115315.f90:21:25:
> 
>     21 |     integer :: c2(iachar('ABCDEFGHIJ'(n1:n1)))
>        |                         1
> Error: Argument of IACHAR at (1) must be of length one
> bash: ./a.out: No such file or directory
> 
> is invalid and not reported in the PR. Even if it is not a regression,
> it is a trivial fix for the above error. As far as I can see, the
> valgrind error has gone.
> 
> Regtests on FC43/x86_64 - OK for mainline?
> 
> The patch does not apply to 15-branch because of the changes to
> decl.cc but can be made to do if backporting is desired.

the patch is verging on the obvious and OK from my side.
However, I did not see a testcase attached to the submission.

Since PDT's in the 15-branch lack many of the recent improvements
on mainline, I'd rather leave the discussion whether to backport
to you and others and not make any recommendation.

Thanks for the patch!

Harald