Re: [PATCH, libgfortran] PR124512 Fix build failure on NetBSD

On Sat, Mar 21, 2026 at 7:54 PM Jerry DeLisle <[email protected]> wrote:
>
> Hi all,
>
> The attached patch from Chris, fixes a build error by checking if the neccessary
> pthread implementation is available on the system and if not, disables building
> -lcaf_shmem.
>
> Regression tested on x86_64-linux. I did regenerate with autoreconf 2.69 as
> stated in the PR.
>
> This fixes a P1.  I prefer good review although it looks OK to me.

LGTM.

Richard.

> Regards,
>
> Jerry
>
> Author: Christopher Albert <[email protected]>
> Date:   Fri Mar 20 23:09:26 2026 +0100
>
>      libgfortran: Disable caf_shmem without usable process-shared pthreads
> [PR124512]
>
>      Use a compile-time usability probe for the process-shared pthread API
>      required by caf_shmem and only build libcaf_shmem when that probe succeeds.
>
>      caf_shmem needs process-shared pthread primitives that are visible through
>      the default pthread headers.  AX_PTHREAD already established the baseline
>      pthread flags; this additional check only verifies that the specific
>      process-shared API surface is usable for caf/shmem/thread_support.c.
>
>              PR fortran/124512
>
>      libgfortran/ChangeLog:
>
>              * Makefile.am: Adjust the dependencies.
>              * Makefile.in: Regenerate.
>              * configure: Regenerate.
>              * configure.ac: Add new check.
>
>      Signed-off-by: Christopher Albert <[email protected]>