Re: [Patch, fortran] PR120140 - generic type-bound procedure, defined assignment, and subarray reference

Harald Anlauf <[email protected]>
Newsgroups gmane.comp.gcc.patches,gmane.comp.gcc.fortran
Message-ID <[email protected]>
Hi Paul,

Am 13.04.26 um 11:21 AM schrieb Paul Richard Thomas:
> Hello All,
> 
> The attached fixes the remaining dependency issues, where more than
> one temporary is required for elemental subroutine calls. Extra tests
> are now enabled in defined_assignment_13.f90.
> 
> Some of you have tested and commented on an earlier version of the
> patch, for which thanks are due. This submission is completely
> refactored and simplified. Note also the condition that the extra
> temporary should only correspond to INTENT_IN arguments. Using
> write-in and write-out for other intents would enable non-conforming
> code because of the possibility of aliasing.
> 
> Regtests OK on FC43/x86_64.  OK for mainline?

The new comment seems to have gotten crippled:

  /* Makes a temporary variable expression based on the characteristics of
-   a given variable expression.  */
+   a given variable expression.  If allocatable is set, the temporary is
+   unconditionally allocatable*/
                               ^^^

In the updated testcase the two lines are now obsolete:
(this part ... properly)

@@ -261,21 +268,30 @@ contains
      ! l.h.s. vector indices, r.h.s. array section
      ! (this part currently disabled because the temporary for the l.h.s.
      ! is not yet implemented properly)


Thanks,
Harald

> Regards
> 
> Paul
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.