Re: PATCH 6/22] Coarray caf_shmem final patch set
Hans-Peter Nilsson <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
> Date: Tue, 24 Feb 2026 13:31:18 -0800 > From: Jerry D <[email protected]> > From: Andre Vehreschild <[email protected]> > Subject: [PATCH] Fortran: Enable coarray tests for multi image use [PR88076] > > Change some of regression tests to run on single and multiple images. > Add some new tests. > > PR fortran/88076 > > gcc/testsuite/ChangeLog: > > * gfortran.dg/coarray/alloc_comp_4.f90: Make multi image > compatible. > * gfortran.dg/coarray/atomic_2.f90: Same. > * gfortran.dg/coarray/caf.exp: Also test caf_shmem and choose > eight images as a default. > * gfortran.dg/coarray/coarray_allocated.f90: Add multi image > support. > * gfortran.dg/coarray/coindexed_1.f90: Same. > * gfortran.dg/coarray/coindexed_3.f08: Same. > * gfortran.dg/coarray/coindexed_5.f90: Same. > * gfortran.dg/coarray/dummy_3.f90: Same. > * gfortran.dg/coarray/event_1.f90: Same. > * gfortran.dg/coarray/event_3.f08: Same. > * gfortran.dg/coarray/event_4.f08: Same. > * gfortran.dg/coarray/failed_images_2.f08: Same. > * gfortran.dg/coarray/image_status_1.f08: Same. > * gfortran.dg/coarray/image_status_2.f08: Same. > * gfortran.dg/coarray/lock_2.f90: Same. > * gfortran.dg/coarray/poly_run_3.f90: Same. > * gfortran.dg/coarray/scalar_alloc_1.f90: Same. > * gfortran.dg/coarray/stopped_images_2.f08: Same. > * gfortran.dg/coarray/sync_1.f90: Same. > * gfortran.dg/coarray/sync_3.f90: Same. > * gfortran.dg/coarray/co_reduce_string.f90: New test. > * gfortran.dg/coarray/sync_team.f90: New test. Because some test-files were edited, adding calls to sleep, rather than left alone, they show up as regressions in my autotester for cris-elf, which has no implementation of sleep. Simulators for bare-metal newlib targets rarely do, (Yes, the added coverage by including fortran even though it's highly unlikely to be exercised IRL is really beneficial: I've seen the added coverage matter a couple of times.) I don't really know if making the tests "multi image compatible" by changing them, was a must or if it was an option to only add tests. I can't tell, I'm just pointing out the consequence of editing tests rather than just adding some. Logged as PR libfortran/125005, for which I'm about to post a patch-set. brgds, H-P