Re: [Patch] libgomp: Add stub omp_control_tool for OMPT

On 5/12/26 16:20, Tobias Burnus wrote:
> This patch adds the omp_control_tool API routine, returning for now
> alwaysomp_control_tool_notool - it also adds the enum/PARAMETER related
> to that routine plusomp_pause_stop_tool. I also updated the .texi file for this change. Tobias
> PS: This will become more useful once OMPT supports lands (which is WIP).

I have a couple nits about the documentation changes.

> diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi
> index b4442069f66..c047cc0ff0e 100644
> --- a/libgomp/libgomp.texi
> +++ b/libgomp/libgomp.texi
> @@ -644,7 +644,7 @@ to address of matching mapped list item per 5.1, Sect. 2.21.7.2 @tab N @tab
>  @item Multi-word directives now use underscore by default @tab N @tab
>  @item Relaxed Fortran restrictions to the @code{aligned} clause @tab N @tab
>  @item Mapping lambda captures @tab N @tab
> -@item New @code{omp_pause_stop_tool} constant for omp_pause_resource @tab N @tab
> +@item New @code{omp_pause_stop_tool} constant for omp_pause_resource @tab Y @tab

That should be @code{omp_pause_resource}, right?

> +@node Tool Control Routine
> +@section Tool Control Routine
> +
> +Routine that supports the use of the OpenMP tools interface (OMPT).
> +
> +@menu
> +* omp_control_tool:: pass commands to a tool
> +@end menu
> +
> +@node omp_control_tool
> +@subsection @code{omp_control_tool} -- pass commands to a tool
> +@table @asis
> +@item @emph{Description}:
> +The @code{omp_control_tool} routine can be used to pass commands to a tool. The
> +values for @var{modifier} and @var{arg} are specific for the particular tool;
> +for Fortran, @var{arg} is NULL.  The following predefined values for
> +@var{command} are supported by all tools:

Having read this far, I'm wondering what a "tool" is; that's a 
completely generic term.  Could we use the term "monitoring tool" 
somewhere early on in the discussion?  And/or add a sentence that 
describes what kind of "tools" these are?

-Sandra