Re: [PATCH] PR93727 Add EX format rounding for truncated hex mantissa
Jerry D <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
On 5/27/26 11:58 AM, Harald Anlauf wrote: > Hi Jerry! > > Am 27.05.26 um 3:12 AM schrieb Jerry D: >> The attached patch with assistance implements the various rounding modes for >> the WRITE with EX hexadecimal float output. >> >> This continues the effort to get the full EX support completed. A followup >> patch will take care of the READ EX portion. >> >> This has been regression tested on x86_64. >> >> OK for mainline? > > This looks good to me, so good for mainline. > > I see one issue when compiling on x86_64-pc-linux-gnu: the snprintf > in libgfortran/io/write_float.def has a mismatch between the format > and the passed parameter (llX == long long unsigned int vs. > GFC_UINTEGER_8). I tried to locally cast the passed value, see > attached patch. This got rid of the warning here. > > Can you try yourself? Maybe this also fixes the failures on Power. > > Thanks for the patch! > > Harald > I had the the same patch as yours stashed just in case. I was not able to see the warning you are seeing, but I will apply yours, test, and commit. The power issue is odd and so it goes. We will get it sorted out soon. I also have a read_ex ready to submit sometime in the next day or so. Cheers, Jerry