Re: [PATCH 1/2] libgfortran: Use MapViewOfFileEx instead of MapViewOfFileExNuma in caf_shmem
Peter Damianov <[email protected]>
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
On 2026-05-29 08:57, Tobias Burnus wrote: > Peter Damianov wote: >> MapViewOfFileExNuma is only present when _WIN32_WINNT >= 0x0600 >> (Windows Vista >> or later). The code is passing NUMA_NO_PREFERRED_MODE, and that is >> documented as: >> >> No NUMA node is preferred. This is the same as calling the >> MapViewOfFileEx function. > > ... > >> * caf/shmem/shared_memory.c (shared_memory_init): Use MapViewOfFileEx >> instead of MapViewOfFileExNuma. > > LGTM – as I believe that you don't have commit rights, I pushed the > commit as:r17-925-ga0a4ee875a49c7 / > https://gcc.gnu.org/r17-925-ga0a4ee875a49c7 Thanks for the patch! > Tobias Thanks Tobias, Any opinions on the other patch? I can confirm it fixed that warning for me. It shouldn't be much to review either.