Re: [PATCH} Fix fortran: [PR126170] Fix LTO ICE in copy_function_or_variable
Jerry D <[email protected]> Sat, 11 Jul 2026 11:05:49 -0700
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
On 7/10/26 8:39 PM, H.J. Lu wrote: > On Sat, Jul 11, 2026 at 12:45 AM Jerry D <[email protected]> wrote: >> >> On 7/10/26 7:24 AM, Paul Richard Thomas wrote: >>> Hi Jerry, >>> >>> This looks good to me, with a couple of wee grumbles: >>> >>> (1) + /* Same fix-up, for the finalizer wrapper symbol. */ >>> These chunks are 346 lines apart. Entropy will not be increased by >>> repeating the first comment. >> >> Will do.> >>> (2) s/CONTAINS'ed/contained/ :-) >> >> Late night typing, what was I thinking! Fixed it last night and forgot to >> redo the diff. >> >>> >>> (3) Finally, since PR125051, which uncovered this one, was backported, >>> surely this patch should be backported too? >> >> Will do.> >>> OK for mainline and backporting. >>> >>> Thanks for the patch. >>> >>> Paul >> >> Thanks for the review. >> > > This caused: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=126210 > Obvious fix: The master branch has been updated by Jerry DeLisle <[email protected]>: https://gcc.gnu.org/g:69a2daacba6353d1aab3118415b89afd479c4c76 commit r17-2332-g69a2daacba6353d1aab3118415b89afd479c4c76 Author: Jerry DeLisle <[email protected]> Date: Sat Jul 11 10:35:29 2026 -0700