Re: [PATCH] Fortran, OpenMP: Consolidate iterator group start/finish code

Tobias Burnus <[email protected]> Mon, 20 Jul 2026 10:47:25 +0200
Newsgroups gmane.comp.gcc.patches,gmane.comp.gcc.fortran
Message-ID <[email protected]>
Dear Sandra,

Sandra Loosemore wrote:
> This patch consolidates some repetitive code from gfc_trans_omp_clauses
> into new functions, and adds some comments.  There are no functional
> changes.
(This is for both the data-mapping clauses and for the depend/affinity 
clausse, which all support an 'iterator' modifier.)

> gcc/fortran/ChangeLog
> 	* trans-openmp.cc (handle_iterator):  Add comments.  Rename
> 	iter_block parameter to outer_block, since that's what's actually
> 	being passed; the start/end/step expressions are outside the scope
> 	of the iterator variables.
> 	(start_iterator_group, finish_iterator_group): New functions,
> 	broken out from...
> 	(gfc_trans_omp_clauses): ...here.

LGTM - and thanks for the cleanup!

Tobias