Re: [PATCH] libgomp: Revise libgomp/Fortran support conditionals
Peter0x44 <[email protected]> Thu, 30 Jul 2026 17:34:12 +0200
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.fortran |
|---|---|
| Message-ID | <[email protected]> |
On 2026-07-30 15:15, Thomas Schwinge wrote: > Hi Peter! > I'm confirming that broken behavior with your > <https://github.com/Peter0x44/w64devkit/blob/22a780033053c041af05a6ff9c3012454ea628fe/src/crossgcc-libgomp-gfortran-path.patch>. > > But: that 'crossgcc-libgomp-gfortran-path.patch' isn't the patch I've > sent, but is some mangled variant of it, and applying that one doesn't > change 'libgomp/configure.ac', 'libgomp/configure' in the expected way. > Things certainly work fine if you correctly apply the patch I've sent: > > $ find ~/W/ -name omp_lib\* > [...]/W/lib/gcc/x86_64-w64-mingw32/16.1.0/finclude/omp_lib.mod > > [...]/W/lib/gcc/x86_64-w64-mingw32/16.1.0/finclude/omp_lib_kinds.mod > [...]/W/lib/gcc/x86_64-w64-mingw32/16.1.0/finclude/omp_lib.f90 > [...]/W/lib/gcc/x86_64-w64-mingw32/16.1.0/finclude/omp_lib.h > $ WINEPATH=$HOME/W/bin wine64 gfortran.exe -fopenmp o.f90 > 0138:fixme:ntdll:NtQuerySystemInformation info_class > SYSTEM_PERFORMANCE_INFORMATION > $ OMP_NUM_THREADS=5 wine64 ./a.exe > Hello from thread 3 > Hello from thread 2 > Hello from thread 1 > Hello from thread 4 > Hello from thread 0 Indeed. Somehow, when I gave the agent the link and asked it to update the patch it decided it made more sense to recreate the hunks manually instead of just downloading the patch exactly. I thought the AIs weren't so dumb. That is my bad and sorry for wasting your time. Confirmed solves the issue and approved! Regards, Peter