Re: RFA: libjava seems to miss some files for win32
Kai Tietz <[email protected]>
| Newsgroups | gmane.comp.gcc.devel,gmane.comp.gcc.java.devel |
|---|---|
| Message-ID | <[email protected]> |
2009/7/18 Dave Korn <[email protected]>: > Andrew Pinski wrote: >> On Sat, Jul 18, 2009 at 12:08 PM, Andrew Haley<[email protected]> wrote: >>> Don't use uintptr_t, use unsigned int __attribute__((mode(PTR)). This >>> is built-in to gcc, not a dependency on the host libc which might not >>> be c99..' >> >> Except uintptr_t is required to be provided by a non hosted compiler like GCC. > > Come to think of it, we should use the __UINTPTR_TYPE__ thingy provided by > jsm's recent stdint patch, shouldn't we? > > cheers, > DaveK > Well, this sounds good. I wasn't aware that __UINTPTR_TYPE__ is present. I just was aware of the SIZE, and PTRDIFF builtin macros, which aren't useful here for all targets. Maybe a __ULONGPTR_TYPE__ should be added as internal macro, too. Because sometimes the widest scalar type between MAX(sizeof(long), sizeof(void *)) is necessary, too. E.g. in libiberty there are such cases I remember. Cheers, Kai -- | (\_/) This is Bunny. Copy and paste | (='.'=) Bunny into your signature to help | (")_(") him gain world domination