Re: [PATCH] Define FFI_SIZEOF_JAVA_RAW to 4 for x32
"H.J. Lu" <[email protected]>
| Newsgroups | gmane.comp.lib.ffi.general,gmane.comp.gcc.java.patches,gmane.comp.gcc.patches |
|---|---|
| Message-ID | <CAMe9rOoOJVHV7XjpBSNDPi-T9_oiFCKkxc2uXADKGoR=N0=MCA@mail.gmail.com> |
On Wed, Jul 18, 2012 at 11:44 AM, Uros Bizjak <[email protected]> wrote: > On Wed, Jul 18, 2012 at 6:27 PM, H.J. Lu <[email protected]> wrote: > >>> This patch defines FFI_SIZEOF_JAVA_RAW to 4 for x32, similar to MIPS n32. >>> It fixed: >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53982 >> >> Here is the patch with updated ChangeLog entry. X32 has the same issue >> as MIPS n32, which was fixed by FFI_SIZEOF_JAVA_RAW: >> >> http://gcc.gnu.org/ml/gcc-patches/2007-11/msg01612.html >> http://gcc.gnu.org/ml/gcc-patches/2007-12/msg00005.html >> >> The same fix is needed for x32. OK for trunk? >> >> 2012-07-16 H.J. Lu <[email protected]> >> >> * src/x86/ffitarget.h: Check __ILP32__ instead of __LP64__ for >> x32. >> (FFI_SIZEOF_JAVA_RAW): Defined to 4 for x32. > > How did you tested this patch? Does it fix all the problems from > PR53982, including the one that is not 100% reproducible? > I tested it on Linux/x32. All libjava tests are passing now for x32 with this patch. -- H.J.