Re: [PATCH] java: Use build_qualified_type instead of build_type_variant.

Mark Wielaard <[email protected]> Wed, 09 Jul 2014 12:57:59 +0200
Newsgroups gmane.comp.gcc.patches,gmane.comp.gcc.java.patches
Message-ID <[email protected]>
On Wed, 2014-07-09 at 12:23 +0200, Richard Biener wrote:
> On Tue, Jul 8, 2014 at 10:12 PM, Mark Wielaard <[email protected]> wrote:
> > The java frontend is one of the only places where build_type_variant is
> > still used. New code should use build_qualified_type. See gcc/tree.h.
> >
> > Build and tested on x86_64-unknown-linux-gnu.
> 
> Ok.

Thanks. Pushed.

> Can build_type_variant be removed now?

Not yet. There are still a few usages that are easy to change to
build_qualified_type like the ones in the java frontend.

But there are 3 cases that I haven't figured out yet. c-common, ada and
lto all use it in their implementation of handle_noreturn_attribute and
c-common and lto in handle_const_attribute. I think the c-common one is
correct, but maybe there is a reason for them to be slightly different.

Cheers,

Mark