Re: [patch] Don't encode the minor version in the gcj abi version
Matthias Klose <[email protected]> Thu, 28 Apr 2016 13:45:30 +0200
| Newsgroups | gmane.comp.gcc.java.patches,gmane.comp.gcc.patches |
|---|---|
| Message-ID | <[email protected]> |
On 28.04.2016 12:52, Rainer Orth wrote: > Rainer Orth <[email protected]> writes: > >> Matthias Klose <[email protected]> writes: >> >>> Bumping the version from from 6.0.0 to 6.1.0 broke gcj, because the minor >>> version is still encoded in the gcj abi, not seen during development of the >>> 6 series until it was bumped for the final release. >> >> This is PR java/70839. > > I just noticed that your patch is incomplete: it leaves the now unused > minor around and incorrectly talks about sub-minor versions... > > Here's what I had in the PR instead: > > 2016-04-28 Rainer Orth <[email protected]> > > PR java/70839 > * decl.c (parse_version): Remove minor handling. yes, that looks good. Can't approve it myself.