Re: [PATCH] Fix FFI return type for closures in the java interpreter
Tom Tromey <[email protected]> Tue, 28 Jun 2016 02:08:04 -0600
| Newsgroups | gmane.comp.gcc.patches,gmane.comp.gcc.java.patches |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "Matthew" == Matthew Fortune <[email protected]> writes: Matthew> I've identified a latent bug in the java interpreter that affects MIPS Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit Matthew> big endian target with int as 32-bit. [...] Matthew> libjava/ Matthew> * interpret-run.cc: Use ffi_arg for FFI integer return types. Matthew> libjava/testsuite/ Matthew> * libjava.jar/arraysort.java: New file. Matthew> * libjava.jar/arraysort.jar: New file. Matthew> * libjava.jar/arraysort.out: New file. Matthew> * libjava.jar/arraysort.xfail: New file. Tom> This is ok. It occurred to me that this might not be correct on platforms using the Java raw API; which I think is just x86. I'm actually not sure -- I don't remember (if I ever knew) if the raw API has the same return-value promotion rules as the ordinary API. Could you check? I think a -m32 build ought to show it. Maybe your x86-64 build already did this? thanks, Tom