Re: [PATCH] contrib: Cleanup downloaded archives in download_prerequisites

On Fri, 31 Jul 2026, Даниил Гусев wrote:

> I'm not aware of any discussion behind dropping the cleanup step -
> from what I can tell it was incidental.

It was suggested in review:
https://inbox.sourceware.org/gcc-patches/[email protected]/

(and I would agree with Paolo — the script should not delete the files)

> download_prerequisites was introduced in 2010 (commit 69baf0a) and
> explicitly removed the downloaded archives at the end:
> 
>     rm $MPFR.tar.bz2 $GMP.tar.bz2 $MPC.tar.gz || exit 1
> 
> That stayed in place for about three years.
> 
> In 2013, commit a8db599 ("download_prerequisites: Download isl and
> cloog conditionally") dropped that line while adding conditional
> isl/cloog handling. The commit message is entirely about making
> isl/cloog optional and says nothing about archive cleanup, so the
> removal looks like an unrelated side effect rather than a deliberate
> change.
> 
> So my patch is restoring the 2010-2013 behavior rather than
> introducing something new. --save-archives/--no-save-archives is
> there for people who want to keep the archives around (offline
> rebuilds etc).

I would like an explanation of the purpose of restoring the 2013
behavior. Did anyone request that?

Alexander