Re: [PATCH v1 0/2] arm: recognize vdupq idioms [PR124043]

Torbjörn Svensson (azoff) <[email protected]>) commented on the code:
Other than the obvious extra newline in the first commit, I do not know much about what this code does.

Running the change (on top of r17-2833-g32657f29f91871) does change XFAIL to PASS for the tests in the PR, so I guess this is better.

> +++ gcc/testsuite/gcc.target/arm/crypto-vsha1cq_u32.c
> @@ -33,3 +33,3 @@
>  /* { dg-final { scan-assembler-times {sha1c.32\tq[0-9]+, q[0-9]+} 5 } } */
>  /* { dg-final { scan-assembler-times {vdup.32\tq[0-9]+, (?:r[0-9]+|d[0-9]+\[[0-9]+\])} 4 { xfail { arm_thumb2 && arm_hf_eabi } } } } */
> -/* { dg-final { scan-assembler-times {vmov.32\tr[0-9]+, d[0-9]+\[[0-9]+\]} 3 } } */
> +
Maybe you want to avoid inserting the blank line here just to remove it in the next commit.


--
https://forge.sourceware.org/gcc/gcc/pulls/208#issuecomment-7016