Re: [PATCH v3] expand: Split divisions with near-power-of-two divisors [PR middle-end/125708]

On 7/26/2026 8:49 PM, Hongtao Liu wrote:
> On Mon, Jul 20, 2026 at 6:01 PM liuhongt <[email protected]> wrote:
>> updated in v3:
>>>> diff --git a/gcc/testsuite/gcc.c-torture/execute/pr125708-1.c b/gcc/testsuite/gcc.c-torture/execute/pr125708-1.c
>>>> new file mode 100644
>>>> index 00000000000..a5f372fee98
>>>> --- /dev/null
>>>> +++ b/gcc/testsuite/gcc.c-torture/execute/pr125708-1.c
>>> I believe this probably belongs in gcc.dg/torture.  I think we're (in
>>> general) supposed to be using that instead of the older c-torture
>>> framework.  The tests probably need to gate on int32plus given the
>>> constants won't fit in an int for a 16 bit int target.  It'll require
>>> some dg-do directives to be effective for what you're trying to test.
>>>
>> Changed
>>
>>>> +/* { dg-final { scan-assembler-not "idiv" } } */
>>>> +/* { dg-final { scan-assembler-not "\tdiv" } } */
>>>> +/* { dg-final { scan-assembler "cmov" } } */
>>> Any particular reason why only the idiv uses \t?   There's some
>>> inconsistency here.
>> My local worktee name had 'div' in it -- that was just to avoid test failure and not actually needed.
>> changed.
>>
> I'd like to ping for this, it's just a testcase update in v3.
Sorry, my time was very limited last couple weeks due to a family 
issue.   V3 is OK for the trunk.

jeff