Re: [PATCH v8 0/7] Recognize and fold longhand wide-multiplication idioms [PR107090]

Jakub Jelinek <[email protected]> Tue, 4 Aug 2026 19:29:43 +0200
Newsgroups gmane.comp.gcc.patches
Message-ID <anIhhznaXMo4pUKl@tucnak>
On Tue, Aug 04, 2026 at 10:00:45AM -0700, Andrea Pinski wrote:
> Note this would mean the series was not created correctly in the first
> place. And it means it was not tested correctly.
> Also I would have liked the series not squashed and actually fixed up
> such that it was separated out for many different reasons. Including
> but not limited to that it was complex to review in the first place.
> Plus now bootstrap is broken on x86_64.

Note, x86_64 -m32 (like most other 32-bit targets) don't really support
__int128 nor general TImode arithmetics, e.g.
targetm.scalar_mode_supported_p (TImode) is false there.
While clearly the commit started emitting TImode arithmetics into 32-bit
IL.
Something should have been guarded with MAX_FIXED_MODE_SIZE or so...

	Jakub