Re: [PATCH] rs6000: Fix type size checks for __builtin_ppc_atomic_cas_local [PR126513]

On Tue, Aug 04, 2026 at 02:32:21PM +0530, Avinash Jayakar wrote:
> Below patch is to fix PR126513. Bootstrapped and regtested on
> powerpc64le-linux-gnu. Ok for trunk and affected branches (16 and 15)?
> 
> I would need some advice on whether we need to fix it for 16.2 release as well.
> Although the issue reported in PR126513 is a negative test where compiler must
> report error, but currently ICE happens. While testing it I see that case c4
> mentioned in the commit message was also not handled. This is a positive test
> where compiler must produce output, but ICEs and I think this is a bit more
> higher severity issue. So do you think this should go in 16.2?

Neither of that feels like a blocker for the 16.2 release, but otherwise
ice-on-valid-code and ice-on-invalid-code regressions are generally ok to
be exported (unlike e.g. accepts-invalid), so if Michael approves it (I'd
prefer if it is approved by PowerPC person) for trunk, it is ok for 16.2.1
(i.e. after 16.2 is released) and 16.x (but for regressions of the right
categories if safe one actually doesn't need extra approval for the
backports or whomever approves it for trunk can approve it for branches as
well).

	Jakub