[PATCH] Makefile.tpl: mark mail-report.log and mail-report-with-warnings.log as .PHONY

Uros Bizjak <[email protected]>
Newsgroups gmane.comp.gcc.patches
Message-ID <CAFULd4YieyaspK+PHqkuk6oVcDAm7Wp_HyvgaUHpVaTd1O8K-Q@mail.gmail.com>
mail-report.log has no prerequisites, so once it exists Make
considers it up to date on every subsequent invocation and the
recipe never reruns; regenerating it after a fresh test run
currently requires manually removing the file first.

mail-report-with-warnings.log has the same problem despite
depending on warning.log: it always needs to regenerate on
demand rather than only when its prerequisite changes.

Mark both as .PHONY so they rerun on every invocation, matching
their actual use as on-demand report generators rather than
cacheable build artifacts.  warning.log itself is left alone, as
its dependency on build.log is tracked correctly and should keep
using normal timestamp-based rebuilding.

ChangeLog:

* Makefile.tpl (mail-report.log): Mark as .PHONY.
(mail-report-with-warnings.log): Likewise.
* Makefile.in: Regenerate.

Tested on x86_64-pc-linux-gnu.

Uros.
p.diff.txt (text/plain, 1.3 KB)
diff --git a/Makefile.in b/Makefile.in
index 5cca69c3f52..9b353424645 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -2937,6 +2937,7 @@ do-check:
 warning.log: build.log
 	$(srcdir)/contrib/warn_summary build.log > $@
 
+.PHONY: mail-report.log
 mail-report.log:
 	if test x'$(BOOT_CFLAGS)' != x''; then \
 	    BOOT_CFLAGS='$(BOOT_CFLAGS)'; export BOOT_CFLAGS; \
@@ -2945,6 +2946,7 @@ mail-report.log:
 	chmod +x $@
 	echo If you really want to send e-mail, run ./$@ now
 
+.PHONY: mail-report-with-warnings.log
 mail-report-with-warnings.log: warning.log
 	if test x'$(BOOT_CFLAGS)' != x''; then \
 	    BOOT_CFLAGS='$(BOOT_CFLAGS)'; export BOOT_CFLAGS; \
diff --git a/Makefile.tpl b/Makefile.tpl
index 98bd03e9a33..870a82e9118 100644
--- a/Makefile.tpl
+++ b/Makefile.tpl
@@ -1054,6 +1054,7 @@ do-check:
 warning.log: build.log
 	$(srcdir)/contrib/warn_summary build.log > $@
 
+.PHONY: mail-report.log
 mail-report.log:
 	if test x'$(BOOT_CFLAGS)' != x''; then \
 	    BOOT_CFLAGS='$(BOOT_CFLAGS)'; export BOOT_CFLAGS; \
@@ -1062,6 +1063,7 @@ mail-report.log:
 	chmod +x $@
 	echo If you really want to send e-mail, run ./$@ now
 
+.PHONY: mail-report-with-warnings.log
 mail-report-with-warnings.log: warning.log
 	if test x'$(BOOT_CFLAGS)' != x''; then \
 	    BOOT_CFLAGS='$(BOOT_CFLAGS)'; export BOOT_CFLAGS; \
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.