Re: [PATCH 01/12] contrib: match the split insn-emit sources in filter-clang-warnings.py

On Thu, Aug 13, 2026 at 6:27 AM <[email protected]> wrote:
>
> From: Kyrylo Tkachov <[email protected]>
>
> skip_warning matches its keys as substrings of the file name, so the
> 'insn-emit.cc' entry stopped matching anything when r14-4756-g184378027e9
> split the file into insn-emit-1.cc and friends.  The
> -Wtautological-compare warnings it was meant to hide have been reported
> ever since.
>
> Key on 'insn-emit', as the entries for the equally split gimple-match and
> generic-match already do.
>
> Bootstrapped on aarch64-none-linux-gnu.
> Ok for trunk?

Ok

>
> contrib/ChangeLog:
>
>         * filter-clang-warnings.py (skip_warning): Match insn-emit rather
>         than insn-emit.cc.
>
> Signed-off-by: Kyrylo Tkachov <[email protected]>
> ---
>  contrib/filter-clang-warnings.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/filter-clang-warnings.py b/contrib/filter-clang-warnings.py
> index 8eec366b4bc..9de005990b5 100755
> --- a/contrib/filter-clang-warnings.py
> +++ b/contrib/filter-clang-warnings.py
> @@ -55,7 +55,7 @@ def skip_warning(filename, message):
>              # made default or removed:
>              'ipa-strub.cc': ['-Wunused-but-set-variable'],
>              'insn-modes.cc': ['-Wshift-count-overflow'],
> -            'insn-emit.cc': ['-Wtautological-compare'],
> +            'insn-emit': ['-Wtautological-compare'],
>              'insn-attrtab.cc': ['-Wparentheses-equality'],
>              'omp-builtins.def': ['-Wc++11-narrowing'],
>              'wide-int.h': ['-Wnontrivial-memcall'],
> --
> 2.50.1 (Apple Git-155)
>