Re: [PATCH 1/2] Add vect_finish_stmt_generation for sequences

From 71fac902db7ae5a25b4aa7afeedf1f6dea00250f Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <[email protected]>
Date: Sat, 15 Aug 2026 08:35:23 +0800
Subject: [PATCH] Fix Add vect_finish_stmt_generation for sequences

Signed-off-by: H.J. Lu <[email protected]>
---
 gcc/testsuite/g++.target/i386/pr126788-1.C |  39 +++++
 gcc/testsuite/g++.target/i386/pr126788-2.C | 169 +++++++++++++++++++++
 gcc/testsuite/g++.target/i386/pr126788-3.C |  30 ++++
 gcc/tree-vect-stmts.cc                     |   9 ++
 4 files changed, 247 insertions(+)
 create mode 100644 gcc/testsuite/g++.target/i386/pr126788-1.C
 create mode 100644 gcc/testsuite/g++.target/i386/pr126788-2.C
 create mode 100644 gcc/testsuite/g++.target/i386/pr126788-3.C

diff --git a/gcc/testsuite/g++.target/i386/pr126788-1.C b/gcc/testsuite/g++.target/i386/pr126788-1.C
new file mode 100644
index 00000000000..77e09f9ea54
--- /dev/null
+++ b/gcc/testsuite/g++.target/i386/pr126788-1.C
@@ -0,0 +1,39 @@
+/* { dg-do compile } */
+/* { dg-options "-O -msse2 -std=gnu++17" } */
+/* Keep labels and directives ('.cfi_startproc', '.cfi_endproc').  */
+/* { dg-final { check-function-bodies "**" "" "" { target { ! ia32 } } {^\t?\.} } } */
+
+typedef int  v2si __attribute__((vector_size (8)));
+typedef unsigned int  v2usi __attribute__((vector_size (8)));
+typedef long long v2di __attribute__((vector_size (16)));
+
+/*
+**_Z5func1Dv2_iS_:
+**.LFB[0-9]+:
+**	.cfi_startproc
+**	ret
+**	.cfi_endproc
+**...
+*/
+
+v2si
+func1 (v2si a, v2si b)
+{
+  v2di z = __builtin_convertvector (a, v2di);
+  return __builtin_convertvector (z, v2si);
+}
+
+/*
+**_Z5func2Dv2_iS_:
+**.LFB[0-9]+:
+**	.cfi_startproc
+**	ret
+**	.cfi_endproc
+**...
+*/
+v2usi
+func2 (v2si a, v2si b)
+{
+  v2di z = __builtin_convertvector (a, v2di);
+  return __builtin_convertvector (z, v2usi);
+}
diff --git a/gcc/testsuite/g++.target/i386/pr126788-2.C b/gcc/testsuite/g++.target/i386/pr126788-2.C
new file mode 100644
index 00000000000..2cd2ca2d76a
--- /dev/null
+++ b/gcc/testsuite/g++.target/i386/pr126788-2.C
@@ -0,0 +1,169 @@
+/* { dg-do compile } */
+/* { dg-options "-fno-checking -O2 -march=x86-64-v4 -std=c++20" } */
+
+char __parse_integer___buf[32];
+template <typename _Tp> using remove_reference_t = _Tp;
+template <typename _Tp, typename _Up>
+constexpr bool is_same_v = __is_same (_Tp, _Up);
+template <typename _Tp, typename _Up>
+concept __same_as = is_same_v<_Tp, _Up>;
+template <typename _Tp, typename _Up>
+concept same_as = __same_as<_Up, _Tp>;
+struct __is_integer
+{
+  enum
+  {
+    __value = 1
+  };
+};
+using wstring_view = int;
+template <typename, typename> class basic_format_context;
+template <typename> struct basic_format_parse_context
+{
+  int *begin ();
+  int *end ();
+};
+template <typename, typename> struct formatter;
+namespace __format
+{
+template <typename _CharT>
+concept __char = same_as<_CharT, wchar_t>;
+template <typename> struct _Sink_iter
+{
+};
+template <typename _CharT>
+using __format_context = basic_format_context<_CharT, _CharT>;
+} // namespace __format
+using wformat_context = __format::__format_context<wchar_t>;
+namespace __format
+{
+template <typename _CharT>
+void
+__parse_integer (_CharT *__first, _CharT *)
+{
+  for (int __i = 0; __i < 32 && __first + __i; ++__i)
+    __parse_integer___buf[__i] = __i;
+  __parse_integer (__parse_integer___buf, __parse_integer___buf);
+}
+enum _Pres_type
+{
+};
+template <typename _CharT> struct _Spec
+{
+  void
+  _M_parse_width (int *__first, int *__last,
+                  basic_format_parse_context<_CharT>)
+  {
+    __parse_integer (__first, __last);
+  }
+};
+template <__char _CharT> struct __formatter_int
+{
+  _Pres_type _AsInteger;
+  _CharT
+  _M_do_parse (basic_format_parse_context<_CharT> __pc, _Pres_type)
+  {
+    _Spec<_CharT> __spec;
+    auto __last = __pc.end (), __first = __pc.begin ();
+    __spec._M_parse_width (__first, __last, __pc);
+    return 0;
+  }
+  template <typename>
+  _CharT
+  _M_parse (basic_format_parse_context<_CharT> __pc)
+  {
+    _M_do_parse (__pc, _AsInteger);
+    return 0;
+  }
+};
+template <typename>
+constexpr bool __is_formattable_integer = __is_integer::__value;
+template <typename _Tp>
+concept __formattable_integer = __is_formattable_integer<_Tp>;
+} // namespace __format
+template <__format::__formattable_integer _Tp, __format::__char _CharT>
+struct formatter<_Tp, _CharT>
+{
+  _CharT
+  parse (basic_format_parse_context<_CharT> __pc)
+  {
+    _M_f.template _M_parse<_Tp> (__pc);
+    return 0;
+  }
+  __format::__formatter_int<_CharT> _M_f;
+};
+namespace __format
+{
+enum _Arg_t
+{
+  _Arg_u128
+};
+}
+int _M_val;
+__format::_Arg_t _M_type;
+struct
+{
+  template <typename _Visitor>
+  void
+  _M_visit (_Visitor)
+  {
+    switch (_M_type)
+      {
+        using enum __format::_Arg_t;
+      case _Arg_u128:
+        _Visitor () (_M_val);
+      }
+  }
+} __visit_format_arg___arg;
+template <typename _Visitor>
+void
+__visit_format_arg (_Visitor)
+{
+  __visit_format_arg___arg._M_visit (_Visitor ());
+}
+template <typename, typename> struct basic_format_context
+{
+  template <typename _Tp> using formatter_type = formatter<_Tp, wchar_t>;
+};
+namespace __format
+{
+struct : basic_format_parse_context<wchar_t>
+{
+} _M_pc;
+void _M_scan ();
+struct _Scanner
+{
+  _Scanner (int);
+  virtual void _M_format_arg (unsigned long);
+};
+template <typename _Out, typename _CharT> struct _Formatting_scanner : _Scanner
+{
+  _Formatting_scanner (basic_format_context<_Out, _CharT>, int __str)
+      : _Scanner (__str)
+  {
+  }
+  void
+  _M_format_arg (unsigned long)
+  {
+    __visit_format_arg (
+        [] (auto __arg)
+          {
+            typename basic_format_context<_Out, _CharT>::formatter_type<
+                remove_reference_t<decltype (__arg)>>
+                __f;
+            __f.parse (_M_pc);
+          });
+  }
+};
+template <unsigned = 0>
+_Sink_iter<wchar_t>
+__do_vformat_to (_Sink_iter<wchar_t> x, int __fmt,
+                 __format_context<wchar_t> &__ctx)
+{
+  _Formatting_scanner __scanner (__ctx, __fmt);
+  _M_scan ();
+  return x;
+}
+template _Sink_iter<wchar_t> __do_vformat_to (_Sink_iter<wchar_t>,
+                                              wstring_view, wformat_context &);
+}
diff --git a/gcc/testsuite/g++.target/i386/pr126788-3.C b/gcc/testsuite/g++.target/i386/pr126788-3.C
new file mode 100644
index 00000000000..17723cdcba5
--- /dev/null
+++ b/gcc/testsuite/g++.target/i386/pr126788-3.C
@@ -0,0 +1,30 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -march=x86-64-v4 -std=c++17" } */
+
+extern int _M_current;
+extern int end ();
+struct color
+{
+  char r;
+  struct
+  {
+    unsigned char g;
+    unsigned char b;
+  } m_24bit;
+  color (char g, char b)
+  {
+    m_24bit.g = g;
+    m_24bit.b = b;
+  }
+};
+void
+set_style_bg_color (color)
+{
+  for (;;)
+    {
+      const unsigned char g = _M_current;
+      if (end ())
+	break;
+      set_style_bg_color (color (g, _M_current));
+    }
+}
diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index 070981dbdb3..93d20544817 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -5826,6 +5826,15 @@ vectorizable_conversion (vec_info *vinfo,
 	      vect_finish_stmt_generation (vinfo, stmt_info, new_stmt, gsi);
 	      slp_node->push_vec_def (new_temp2);
 	    }
+	  else if (CONVERT_EXPR_CODE_P (code1))
+	    {
+	      new_stmt = vect_gimple_build (vec_dest, code1, vop0);
+	      new_temp = make_ssa_name (vec_dest, new_stmt);
+	      gimple_set_lhs (new_stmt, new_temp);
+	      vect_finish_stmt_generation (vinfo, stmt_info, new_stmt, gsi);
+
+	      slp_node->push_vec_def (new_stmt);
+	    }
 	  else
 	    {
 	      gimple_seq stmts = NULL;
-- 
2.55.0