Re: [APPROVED][PATCH v1] testsuite: arm: add require effective target for cmse tests

Richard Earnshaw (rearnsha) <[email protected]> approved the changes:
OK with suggested changed

> +++ gcc/testsuite/gcc.target/arm/cmse/cmse-19.c
> @@ -1,7 +1,8 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target arm_v8_1m_mve_ok } */
I think we should add arm_arch_v8_1m_main_mve to target-supports, then use it here and...

> +++ gcc/testsuite/gcc.target/arm/cmse/cmse-19.c
> @@ -2,3 +3,3 @@
>  /* This is a duplicate of cmse-18.c, targetting arm_v8_1m_mve, to make sure
>     FPCXT is enabled.  */
> -/* { dg-options "-mcmse -fdump-rtl-final -march=armv8.1-m.main+mve" } */
> +/* { dg-options "-mcmse -fdump-rtl-final -mcpu=unset -march=armv8.1-m.main+mve" } */
use dg-add-options here.

> +++ gcc/testsuite/gcc.target/arm/cmse/cmse-18.c
> @@ -2,2 +2,3 @@
> +/* { dg-require-effective-target arm_arch_v8m_main_ok } */
>  /* Make sure FPCXT is not enabled.  */
> -/* { dg-options "-mcmse -fdump-rtl-final -march=armv8-m.main+fp" } */
> +/* { dg-options "-mcmse -fdump-rtl-final -mcpu=unset -march=armv8-m.main+fp" } */
This should use `dg-add-options arm_arch_v8m_main` rather than setting it through dg-options.


--
https://forge.sourceware.org/gcc/gcc/pulls/212#issuecomment-7210