Re: [PATCH 3/7] testsuite: require stack protector support in no-stack-protector-attr.C
Jeffrey Law <[email protected]>
| Newsgroups | gmane.comp.gcc.patches |
|---|---|
| Message-ID | <[email protected]> |
On 8/14/2026 1:38 PM, Andrea Pinski wrote: > On Fri, Aug 14, 2026 at 12:31 PM Matt Turner <[email protected]> wrote: >> The test carried two dg-do compile directives: one restricting it to x86 >> and, added later, one excluding only hppa. DejaGnu honors the last one, so >> the x86 restriction never had any effect and the test has run everywhere >> since it was added, which is why hppa needed excluding at all. >> >> Require fstack_protector instead, so the test runs wherever the feature >> exists. This fixes it on alpha, which does not support -fstack-protector >> and warns that the option is unsupported. The hppa exclusion becomes >> redundant, as check_effective_target_fstack_protector already returns 0 >> there. >> >> gcc/testsuite/ChangeLog: >> >> * g++.dg/no-stack-protector-attr.C: Remove the dead dg-do directive >> and the hppa exclusion, and require fstack_protector. > Ok. Note that while Matt has contributed to GCC on and off for over a decade, I'm pretty sure he doesn't have commit privs. I've pushed this patch. Jeff