Re: [PATCH v1] testsuite: force arm_neon for fold-vecperm-insert-1.c on arm*-*-*

Richard Earnshaw via Sourceware Forge <[email protected]>
Newsgroups gmane.comp.gcc.patches
Message-ID <bmm.hlhhx5f75s.gcc.gcc.rearnsha.220.549.REVIEW@forge-stage.sourceware.org>
Richard Earnshaw (rearnsha) <[email protected]>) commented on the code:


> +++ gcc/testsuite/gcc.dg/fold-vecperm-insert-1.c
> @@ -1,5 +1,7 @@
>  /* { dg-do compile { target aarch64*-*-* arm*-*-* x86_64-*-* } } */
> +/* { dg-require-effective-target arm_neon_ok { target arm*-*-* } } */
>  /* { dg-options "-O2 -fdump-tree-forwprop3" } */
> +/* { dg-add-options arm_neon } */
Was this tested on a non-arm target?  I'm not sure if this dg-add-options takes a `{ target arm*-*-*}`, but it feels like this should be similarly restricted to the same as the d-r-e-t check.


--
https://forge.sourceware.org/gcc/gcc/pulls/220#issuecomment-7232
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.