Re: [PATCH v3] gcov: Split atomic bitwise-or for some targets

----- Am 25. Jul 2026 um 22:17 schrieb Jeffrey Law [email protected]:

> On 7/16/2026 5:59 PM, Sebastian Huber wrote:
[...]
>> +static void
>> +split_update_decision_counter (gimple_seq *seq, tree ref, tree counter,
>> +			       tree atomic_ior_32, tree relaxed)
>> +{
>> +  ref = unshare_expr (ref);
>> +
>> +  /* Get the low and high address of the referenced counter */
> Make sure your comments are full sentences.  End them with a period, two
> spaces and the close comment  the same nit is repeated a few times in
> this function.
>> @@ -1191,6 +1244,9 @@ instrument_decisions (array_slice<basic_block> expr,
>> size_t condno,
>>   						    next[k], relaxed);
>>   		  gimple_seq_add_stmt (&seq, flush);
>>   		}
>> +	      else if (use_atomic_split)
>> +		  split_update_decision_counter (&seq, ref, next[k],
>> +						 atomic_ior_32, relaxed);
> Another nit.  It's a bit incconsistent, but our coding guidelines would
> have the call to split_udpate_decision_counter indented 2 positions
> inside the else-if, not 4 positions like you've done.  4 positions would
> be right if you had enclosing curly braces, but those would be redundant
> here (and it does get called out regularly).  So adjust the indention to
> just two positions inside the else-if.
> 
> OK with the nits fixed.  No need for another review round.

Thanks for your review, I checked it in today hopefully with the right fixes.

-- 
embedded brains GmbH & Co. KG
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: [email protected]
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/